Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: Source/core/xml/XMLHttpRequestUpload.h

Issue 79953004: Improve fidelity of XHR progress events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Avoid using default arguments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xml/XMLHttpRequestUpload.h
diff --git a/Source/core/xml/XMLHttpRequestUpload.h b/Source/core/xml/XMLHttpRequestUpload.h
index b9f5ae8cb5f47d40d9434920b7755cc33f1186b8..39b7a13c2051e54f4d7b4f505868f908c8437c86 100644
--- a/Source/core/xml/XMLHttpRequestUpload.h
+++ b/Source/core/xml/XMLHttpRequestUpload.h
@@ -58,10 +58,10 @@ public:
virtual const AtomicString& interfaceName() const OVERRIDE;
virtual ExecutionContext* executionContext() const OVERRIDE;
- void dispatchEventAndLoadEnd(PassRefPtr<Event>);
- void dispatchProgressEvent(unsigned long long bytesSent, unsigned long long totalBytesToBeSent);
+ void dispatchEventAndLoadEnd(const AtomicString&, bool = false, unsigned long long = 0, unsigned long long = 0);
tyoshino (SeeGerritForStatus) 2013/11/25 08:06:15 these default arguments can also be removed.
sof 2013/11/25 11:38:24 Done.
+ void dispatchProgressEvent(unsigned long long, unsigned long long);
- void handleRequestError(const AtomicString& type);
+ void handleRequestError(const AtomicString&);
private:
explicit XMLHttpRequestUpload(XMLHttpRequest*);

Powered by Google App Engine
This is Rietveld 408576698