Chromium Code Reviews Chromium Code Reviews
Issue 79953004:
Improve fidelity of XHR progress events. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. | 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright |
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. |
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright |
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the |
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 51 return adoptPtr(new XMLHttpRequestUpload(xmlHttpRequest)); | 51 return adoptPtr(new XMLHttpRequestUpload(xmlHttpRequest)); |
| 52 } | 52 } |
| 53 | 53 |
| 54 void ref() { m_xmlHttpRequest->ref(); } | 54 void ref() { m_xmlHttpRequest->ref(); } |
| 55 void deref() { m_xmlHttpRequest->deref(); } | 55 void deref() { m_xmlHttpRequest->deref(); } |
| 56 XMLHttpRequest* xmlHttpRequest() const { return m_xmlHttpRequest; } | 56 XMLHttpRequest* xmlHttpRequest() const { return m_xmlHttpRequest; } |
| 57 | 57 |
| 58 virtual const AtomicString& interfaceName() const OVERRIDE; | 58 virtual const AtomicString& interfaceName() const OVERRIDE; |
| 59 virtual ExecutionContext* executionContext() const OVERRIDE; | 59 virtual ExecutionContext* executionContext() const OVERRIDE; |
| 60 | 60 |
| 61 void dispatchEventAndLoadEnd(PassRefPtr<Event>); | 61 void dispatchEventAndLoadEnd(const AtomicString&, bool = false, unsigned lon g long = 0, unsigned long long = 0); |
|
tyoshino (SeeGerritForStatus)
2013/11/25 08:06:15
these default arguments can also be removed.
sof
2013/11/25 11:38:24
Done.
| |
| 62 void dispatchProgressEvent(unsigned long long bytesSent, unsigned long long totalBytesToBeSent); | 62 void dispatchProgressEvent(unsigned long long, unsigned long long); |
| 63 | 63 |
| 64 void handleRequestError(const AtomicString& type); | 64 void handleRequestError(const AtomicString&); |
| 65 | 65 |
| 66 private: | 66 private: |
| 67 explicit XMLHttpRequestUpload(XMLHttpRequest*); | 67 explicit XMLHttpRequestUpload(XMLHttpRequest*); |
| 68 | 68 |
| 69 virtual void refEventTarget() OVERRIDE { ref(); } | 69 virtual void refEventTarget() OVERRIDE { ref(); } |
| 70 virtual void derefEventTarget() OVERRIDE { deref(); } | 70 virtual void derefEventTarget() OVERRIDE { deref(); } |
| 71 | 71 |
| 72 XMLHttpRequest* m_xmlHttpRequest; | 72 XMLHttpRequest* m_xmlHttpRequest; |
| 73 EventTargetData m_eventTargetData; | 73 EventTargetData m_eventTargetData; |
| 74 | 74 |
| 75 // Last progress event values; used when issuing the | 75 // Last progress event values; used when issuing the |
| 76 // required 'progress' event on a request error or abort. | 76 // required 'progress' event on a request error or abort. |
| 77 unsigned long long m_lastBytesSent; | 77 unsigned long long m_lastBytesSent; |
| 78 unsigned long long m_lastTotalBytesToBeSent; | 78 unsigned long long m_lastTotalBytesToBeSent; |
| 79 }; | 79 }; |
| 80 | 80 |
| 81 } // namespace WebCore | 81 } // namespace WebCore |
| 82 | 82 |
| 83 #endif // XMLHttpRequestUpload_h | 83 #endif // XMLHttpRequestUpload_h |
| OLD | NEW |
