Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: Source/core/xml/XMLHttpRequest.h

Issue 79953004: Improve fidelity of XHR progress events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Also deliver faithful 'progress' events on request error Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xml/XMLHttpRequest.h
diff --git a/Source/core/xml/XMLHttpRequest.h b/Source/core/xml/XMLHttpRequest.h
index aa1fdff3c5446a3e1dc3bde4d227677e73d1638b..bf4ac80257ab39f00c6130df337594e4c9c7cffc 100644
--- a/Source/core/xml/XMLHttpRequest.h
+++ b/Source/core/xml/XMLHttpRequest.h
@@ -186,9 +186,12 @@ private:
// Dispatches an event of the specified type to m_upload and
// m_progressEventThrottle.
tyoshino (SeeGerritForStatus) 2013/11/25 05:06:31 now, this method doesn't dispatch events to m_uplo
sof 2013/11/25 07:40:04 Done.
- void dispatchEventAndLoadEnd(const AtomicString&);
+ void dispatchEventAndLoadEnd(const AtomicString&, long long, long long);
- void dispatchThrottledProgressEvent();
+ // Dispatches a response progress event to m_progressEventThrottle.
+ // If loaded and total values are not supplied, these will be
+ // derived from m_receivedLength and m_response.
+ void dispatchThrottledProgressEvent(const AtomicString&, long long = 0, long long = 0);
// Does clean up common for all kind of didFail() call.
void handleDidFailGeneric();
@@ -199,7 +202,7 @@ private:
// Handles didFail() call for timeout.
void handleDidTimeout();
- void handleRequestError(ExceptionCode, const AtomicString&);
+ void handleRequestError(ExceptionCode, const AtomicString&, long long, long long);
OwnPtr<XMLHttpRequestUpload> m_upload;

Powered by Google App Engine
This is Rietveld 408576698