Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/core/xml/XMLHttpRequest.h

Issue 79953004: Improve fidelity of XHR progress events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Also deliver faithful 'progress' events on request error Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005, 2006 Alexey Proskuryakov <ap@nypop.com> 3 * Copyright (C) 2005, 2006 Alexey Proskuryakov <ap@nypop.com>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * Copyright (C) 2012 Intel Corporation 5 * Copyright (C) 2012 Intel Corporation
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Lesser General Public 8 * modify it under the terms of the GNU Lesser General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 void clearVariablesForLoading(); 178 void clearVariablesForLoading();
179 // Returns false iff reentry happened and a new load is started. 179 // Returns false iff reentry happened and a new load is started.
180 bool internalAbort(DropProtection = DropProtectionSync); 180 bool internalAbort(DropProtection = DropProtectionSync);
181 // Clears variables holding response header and body data. 181 // Clears variables holding response header and body data.
182 void clearResponse(); 182 void clearResponse();
183 void clearRequest(); 183 void clearRequest();
184 184
185 void createRequest(ExceptionState&); 185 void createRequest(ExceptionState&);
186 186
187 // Dispatches an event of the specified type to m_upload and 187 // Dispatches an event of the specified type to m_upload and
188 // m_progressEventThrottle. 188 // m_progressEventThrottle.
tyoshino (SeeGerritForStatus) 2013/11/25 05:06:31 now, this method doesn't dispatch events to m_uplo
sof 2013/11/25 07:40:04 Done.
189 void dispatchEventAndLoadEnd(const AtomicString&); 189 void dispatchEventAndLoadEnd(const AtomicString&, long long, long long);
190 190
191 void dispatchThrottledProgressEvent(); 191 // Dispatches a response progress event to m_progressEventThrottle.
192 // If loaded and total values are not supplied, these will be
193 // derived from m_receivedLength and m_response.
194 void dispatchThrottledProgressEvent(const AtomicString&, long long = 0, long long = 0);
192 195
193 // Does clean up common for all kind of didFail() call. 196 // Does clean up common for all kind of didFail() call.
194 void handleDidFailGeneric(); 197 void handleDidFailGeneric();
195 // Handles didFail() call not caused by cancellation or timeout. 198 // Handles didFail() call not caused by cancellation or timeout.
196 void handleNetworkError(); 199 void handleNetworkError();
197 // Handles didFail() call triggered by m_loader->cancel(). 200 // Handles didFail() call triggered by m_loader->cancel().
198 void handleDidCancel(); 201 void handleDidCancel();
199 // Handles didFail() call for timeout. 202 // Handles didFail() call for timeout.
200 void handleDidTimeout(); 203 void handleDidTimeout();
201 204
202 void handleRequestError(ExceptionCode, const AtomicString&); 205 void handleRequestError(ExceptionCode, const AtomicString&, long long, long long);
203 206
204 OwnPtr<XMLHttpRequestUpload> m_upload; 207 OwnPtr<XMLHttpRequestUpload> m_upload;
205 208
206 KURL m_url; 209 KURL m_url;
207 String m_method; 210 String m_method;
208 HTTPHeaderMap m_requestHeaders; 211 HTTPHeaderMap m_requestHeaders;
209 RefPtr<FormData> m_requestEntityBody; 212 RefPtr<FormData> m_requestEntityBody;
210 String m_mimeTypeOverride; 213 String m_mimeTypeOverride;
211 bool m_async; 214 bool m_async;
212 bool m_includeCredentials; 215 bool m_includeCredentials;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 255
253 // An enum corresponding to the allowed string values for the responseType a ttribute. 256 // An enum corresponding to the allowed string values for the responseType a ttribute.
254 ResponseTypeCode m_responseTypeCode; 257 ResponseTypeCode m_responseTypeCode;
255 AsyncMethodRunner<XMLHttpRequest> m_dropProtectionRunner; 258 AsyncMethodRunner<XMLHttpRequest> m_dropProtectionRunner;
256 RefPtr<SecurityOrigin> m_securityOrigin; 259 RefPtr<SecurityOrigin> m_securityOrigin;
257 }; 260 };
258 261
259 } // namespace WebCore 262 } // namespace WebCore
260 263
261 #endif // XMLHttpRequest_h 264 #endif // XMLHttpRequest_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698