Issue 799463003: MachMessageServer::Interface implementations: minor cleanups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 799463003: MachMessageServer::Interface implementations: minor cleanups (Closed)

Created:
6 years ago by Mark Mentovai

Modified:
6 years ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -22 lines)			Patch
M	util/mach/child_port_handshake.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	util/mach/child_port_handshake.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download
M	util/mach/child_port_server.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	util/mach/child_port_server.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	util/mach/child_port_server_test.cc	View	1 2	3 chunks	+6 lines, -6 lines	0 comments	Download
M	util/mach/exc_server_variants.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

This was inspired by the work to add NotifyServer. These changes are being made for ...

6 years ago (2014-12-11 20:59:18 UTC) #2

Mark Mentovai

6 years ago (2014-12-15 19:47:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
554e75422cdafb30f1b9c8c53cb3e4cbe261389f (presubmit successful).