MachMessageServer::Interface implementations: minor cleanups

util/mach/exc_server_variants.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 458 matching lines @@
           destroy_complex_request);
       if (out_reply->RetCode != KERN_SUCCESS) {
         return true;
       }
 
       out_header->msgh_size =
           sizeof(*out_reply) - sizeof(out_reply->new_state) +
           sizeof(out_reply->new_state[0]) * out_reply->new_stateCnt;
       return true;
     }
+
+    default: {
+      SetMIGReplyError(out_header, MIG_BAD_ID);
+      return false;
+    }
   }
-
-  SetMIGReplyError(out_header, MIG_BAD_ID);
-  return false;
 }
 
 //! \brief A server interface for the `exc` or `mach_exc` Mach subsystems,
 //!     simplified to have only a single interface method needing
 //!     implementation.
 template <typename Traits>
 class SimplifiedExcServer final : public ExcServer<Traits>,
                                   public ExcServer<Traits>::Interface {
  public:
   //! \brief An interface that the different request messages that are a part of
@@ skipping 302 matching lines @@
 kern_return_t ExcServerSuccessfulReturnValue(exception_behavior_t behavior,
                                              bool set_thread_state) {
   if (!set_thread_state && ExceptionBehaviorHasState(behavior)) {
     return MACH_RCV_PORT_DIED;
   }
 
   return KERN_SUCCESS;
 }
 
 }  // namespace crashpad