Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 799273002: Added flag --enable-hosted-app-shim-creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index 485ebb18260378ec168646d5fd08dba0d31c2709..579397117116a4b977f57d69fc6ad5fa9fb18fe9 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -588,12 +588,17 @@ void BrowserWindowCocoa::ShowBookmarkAppBubble(
extensions::CreateOrUpdateBookmarkApp(service, &new_web_app_info);
}
- extensions::ExtensionRegistry* registry =
- extensions::ExtensionRegistry::Get(profile);
- const extensions::Extension* app = registry->GetExtensionById(
- extension_id, extensions::ExtensionRegistry::ENABLED);
-
- web_app::RevealAppShimInFinderForApp(profile, app);
+ // If we're not creating app shims, no need to reveal it in Finder.
+ bool create_app_shims = base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableAppShimCreation);
+ if (create_app_shims) {
+ extensions::ExtensionRegistry* registry =
+ extensions::ExtensionRegistry::Get(profile);
+ const extensions::Extension* app = registry->GetExtensionById(
+ extension_id, extensions::ExtensionRegistry::ENABLED);
+
+ web_app::RevealAppShimInFinderForApp(profile, app);
+ }
} else {
service->UninstallExtension(extension_id,
extensions::UNINSTALL_REASON_INSTALL_CANCELED,

Powered by Google App Engine
This is Rietveld 408576698