Added flag --enable-hosted-app-shim-creation.

Added flag --enable-hosted-app-shim-creation.

When turned on, will create app shims for hosted apps on Mac.

BUG=442171
Committed: https://crrev.com/58e359154acb1850666a15e42baa02c34d87b8ae
Cr-Commit-Position: refs/heads/master@{#309123}

[mitchellj, 2014-12-15 00:51:01]

mitchelljones@chromium.org changed reviewers:
+ benwells@chromium.org

[benwells, 2014-12-15 03:35:03]

https://codereview.chromium.org/799273002/diff/1/chrome/browser/web_applicati...
File chrome/browser/web_applications/web_app.cc (right):

https://codereview.chromium.org/799273002/diff/1/chrome/browser/web_applicati...
chrome/browser/web_applications/web_app.cc:282: if (create_app_shims)
Nit: use {} around multi-line if statements.

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:1305: // Enables app shim creation for bookmark
apps on Mac.
Actually this flag will cause app shims to be created for all hosted apps, not
just bookmark apps. This should be reflected in this comment but more
importantly in the flag name, the constants, and the string resources.

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.h:378: extern const char kEnableAppShimCreation[];
Nit: please keep alphabetically sorted.

[mitchellj, 2014-12-15 03:51:29]

https://codereview.chromium.org/799273002/diff/1/chrome/browser/web_applicati...
File chrome/browser/web_applications/web_app.cc (right):

https://codereview.chromium.org/799273002/diff/1/chrome/browser/web_applicati...
chrome/browser/web_applications/web_app.cc:282: if (create_app_shims)
On 2014/12/15 03:35:03, benwells wrote:
> Nit: use {} around multi-line if statements.

Done.

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:1305: // Enables app shim creation for bookmark
apps on Mac.
On 2014/12/15 03:35:03, benwells wrote:
> Actually this flag will cause app shims to be created for all hosted apps, not
> just bookmark apps. This should be reflected in this comment but more
> importantly in the flag name, the constants, and the string resources.

Good point. I've renamed the flag to be --enable-hosted-app-shim-creation (and
updated comments/strings resources).

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/799273002/diff/1/chrome/common/chrome_switche...
chrome/common/chrome_switches.h:378: extern const char kEnableAppShimCreation[];
On 2014/12/15 03:35:03, benwells wrote:
> Nit: please keep alphabetically sorted.

Done.

[benwells, 2014-12-15 05:10:09]

lgtm

https://codereview.chromium.org/799273002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/799273002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:518: void
BrowserWindowCocoa::ShowBookmarkAppBubble(
Comment (i.e. don't worry about it for this CL): it would be nice not to have a
90 line function for bookmark apps in this part of the code. Maybe it could be
factored out somewhere.

[mitchellj, 2014-12-15 05:20:00]

mitchelljones@chromium.org changed reviewers:
+ rsesek@chromium.org

[mitchellj, 2014-12-15 05:20:01]

Robert, can you please review the changes to browser_window_cocoa in the latest
patch set? Thanks.

[benwells, 2014-12-15 05:36:07]

On 2014/12/15 05:35:46, benwells wrote:

Forgot to mention, please update the description and summary as the flag name
has changed.

[mitchellj, 2014-12-15 05:44:54]

On 2014/12/15 05:36:07, benwells wrote:
> On 2014/12/15 05:35:46, benwells wrote:
> 
> Forgot to mention, please update the description and summary as the flag name
> has changed.

No problem, done.

[Robert Sesek, 2014-12-15 21:32:16]

LGTM

[mitchellj, 2014-12-15 22:27:52]

The CQ bit was checked by mitchelljones@chromium.org

[commit-bot: I haz the power, 2014-12-15 22:29:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/799273002/20001

[commit-bot: I haz the power, 2014-12-16 00:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 00:41:20]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mitchellj, 2014-12-16 02:12:42]

mitchelljones@chromium.org changed reviewers:
+ jar@chromium.org

[mitchellj, 2014-12-16 02:12:43]

jar, could you please review histograms.xml? Thanks.

[mitchellj, 2014-12-18 04:07:19]

mitchelljones@chromium.org changed reviewers:
+ isherman@chromium.org
- jar@chromium.org

[mitchellj, 2014-12-18 04:08:38]

isherman@, could you please review histograms.xml? Thanks.

[Ilya Sherman, 2014-12-18 23:06:12]

histograms.xml lgtm

[Ilya Sherman, 2014-12-18 23:06:22]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-12-18 23:07:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/799273002/40001

[commit-bot: I haz the power, 2014-12-19 01:10:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-19 01:11:31]

Patchset 3 (id:??) landed as
https://crrev.com/58e359154acb1850666a15e42baa02c34d87b8ae
Cr-Commit-Position: refs/heads/master@{#309123}