Data Reduction Proxy bypasses local and unspecified addresses.

Data Reduction Proxy bypasses local and unspecified addresses.

Added bypass rules so that Data Reduction Proxy bypasses local and unspecified addresses.

BUG=444601
Committed: https://crrev.com/7df9f254fad936346aa6f527be36a39eef7961fe
Cr-Commit-Position: refs/heads/master@{#310684}

[tbansal1, 2015-01-05 18:55:13]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[bengr, 2015-01-05 21:41:12]

Change the description to have a <=72 char title, then a blank line, then a more
detailed description of the change, then a blank line, then the bug.

https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
(right):

https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:310:
configurator_->AddHostPatternToBypass("127.0.0.0/8");
You should probably fix <local> instead of adding this rule. The interpretation
of <local> is here:
https://code.google.com/p/chromium/codesearch#chromium/src/net/proxy/proxy_by...

https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:321:
configurator_->AddHostPatternToBypass("::/128");
Please verify that this actually does the right thing.

[tbansal1, 2015-01-07 01:51:14]

https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
(right):

https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:310:
configurator_->AddHostPatternToBypass("127.0.0.0/8");
On 2015/01/05 21:41:12, bengr wrote:
> You should probably fix <local> instead of adding this rule. The
interpretation
> of <local> is here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/proxy/proxy_by...
> 

Filed the bug and added TODO.

https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:321:
configurator_->AddHostPatternToBypass("::/128");
On 2015/01/05 21:41:12, bengr wrote:
> Please verify that this actually does the right thing. 

Verified by adding test cases to net/base/net_util_unittest.cc. I can add those
tests, if required.

[bengr, 2015-01-07 02:00:30]

On 2015/01/07 01:51:14, tbansal1 wrote:
>
https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
> File
> components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
> (right):
> 
>
https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
>
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:310:
> configurator_->AddHostPatternToBypass("127.0.0.0/8");
> On 2015/01/05 21:41:12, bengr wrote:
> > You should probably fix <local> instead of adding this rule. The
> interpretation
> > of <local> is here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/net/proxy/proxy_by...
> > 
> 
> Filed the bug and added TODO.
> 
>
https://codereview.chromium.org/799233003/diff/1/components/data_reduction_pr...
>
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc:321:
> configurator_->AddHostPatternToBypass("::/128");
> On 2015/01/05 21:41:12, bengr wrote:
> > Please verify that this actually does the right thing. 
> 
> Verified by adding test cases to net/base/net_util_unittest.cc. I can add
those
> tests, if required.

Change the CL to refer to "Data Reduction Proxy" instead. Also describe what you
are adding. The format is a title <72 chars, a blank line, a description, a
blank line, a bug.

[bengr, 2015-01-08 21:13:18]

lgtm

[tbansal1, 2015-01-09 01:26:49]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2015-01-09 01:27:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/799233003/20001

[commit-bot: I haz the power, 2015-01-09 02:41:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-09 02:43:04]

Patchset 2 (id:??) landed as
https://crrev.com/7df9f254fad936346aa6f527be36a39eef7961fe
Cr-Commit-Position: refs/heads/master@{#310684}