Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc

Issue 799233003: Data Reduction Proxy bypasses local and unspecified addresses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added TODO describing when local subnet can be removed from bypass rules. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
index 9ce68a4491abb52edff29f38ec8463a33e8385e4..6db23912782f74c9f910a40fd752e353c625c088 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
@@ -306,10 +306,21 @@ void DataReductionProxySettings::AddDefaultProxyBypassRules() {
// localhost
DCHECK(configurator_);
configurator_->AddHostPatternToBypass("<local>");
+ // RFC6890 loopback addresses.
+ // TODO(tbansal): Remove this once crbug/446705 is fixed.
+ configurator_->AddHostPatternToBypass("127.0.0.0/8");
+
+ // RFC6890 current network (only valid as source address).
+ configurator_->AddHostPatternToBypass("0.0.0.0/8");
+
// RFC1918 private addresses.
configurator_->AddHostPatternToBypass("10.0.0.0/8");
configurator_->AddHostPatternToBypass("172.16.0.0/12");
configurator_->AddHostPatternToBypass("192.168.0.0/16");
+
+ // RFC3513 unspecified address.
+ configurator_->AddHostPatternToBypass("::/128");
+
// RFC4193 private addresses.
configurator_->AddHostPatternToBypass("fc00::/7");
// IPV6 probe addresses.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698