Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 799073002: Fix run_tests to always run from the crashpad directory (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M build/run_tests.py View 1 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years ago (2014-12-12 21:46:23 UTC) #2
scottmg
Sorry, I thought you meant you were going to fix it in the binaries, I ...
6 years ago (2014-12-12 21:52:52 UTC) #3
Mark Mentovai
Updated. I like os.pardir better than '..', so I used that.
6 years ago (2014-12-12 22:07:27 UTC) #4
scottmg
lgtm
6 years ago (2014-12-12 22:14:02 UTC) #5
Mark Mentovai
6 years ago (2014-12-12 22:16:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc22dc405d0918cf12b8a8cc329cc008a4bd4e22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698