Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: build/run_tests.py

Issue 799073002: Fix run_tests to always run from the crashpad directory (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/run_tests.py
diff --git a/build/run_tests.py b/build/run_tests.py
index 5f3e971d2dbae16e30650b9438bac6b7b59554a6..324844cbf21950a3714b3530bbda96244929da9e 100755
--- a/build/run_tests.py
+++ b/build/run_tests.py
@@ -18,9 +18,6 @@ import os
import subprocess
import sys
-script_dir = os.path.dirname(__file__)
-crashpad_dir = os.path.dirname(script_dir) if script_dir is not '' else '..'
-
# This script is primarily used from the waterfall so that the list of tests
# that are run is maintained in-tree, rather than in a separate infrastructure
@@ -29,7 +26,14 @@ def main(args):
if len(args) != 1:
print >>sys.stderr, 'usage: run_tests.py {Debug|Release}'
return 1;
- binary_dir = os.path.join(crashpad_dir, 'out', args[0])
+
+ # Until https://code.google.com/p/crashpad/issues/detail?id=4 is fixed, tests
+ # need to be run from a specific working directory.
+ crashpad_dir = \
+ os.path.join(os.path.dirname(os.path.abspath(__file__)), os.pardir)
+ os.chdir(crashpad_dir)
+
+ binary_dir = os.path.join('out', args[0])
tests = [
'client_test',
'minidump_test',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698