Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 799023002: Deprecate AudioListener attributes related to doppler (Closed)

Created:
6 years ago by Raymond Toy
Modified:
6 years ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deprecate AudioListener attributes related to doppler The W3C audio group has agreed to remove the doppler effect from panner nodes. This also means removing the doppler-related attributes and methods from AudioListener. See https://github.com/WebAudio/web-audio-api/issues/455 This just deprecates the attributes and methods from the IDL. The underlying implementation still has support for this. We prefer to remove these all at once when the PannerNode (soon to be deprecated) is completely removed. Manually verified the attributes and method cause deprecation warnings. BUG=439644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187218

Patch Set 1 #

Patch Set 2 : Deprecate instead of remove #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M Source/core/frame/UseCounter.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioListener.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
Raymond Toy
hongchan@: PTAL. tkent@: Please review API changes.
6 years ago (2014-12-12 17:11:52 UTC) #2
hongchan
lgtm
6 years ago (2014-12-12 17:16:46 UTC) #3
tkent
lgtm Please make an entry for this removal in chromestatus.com in order to inform this ...
6 years ago (2014-12-15 06:17:43 UTC) #4
tkent
Of course, deprecation, then removal is much better than sudden removal.
6 years ago (2014-12-15 07:21:31 UTC) #5
Raymond Toy
On 2014/12/15 07:21:31, unavailable until Feburuary wrote: > Of course, deprecation, then removal is much ...
6 years ago (2014-12-15 19:16:08 UTC) #6
Raymond Toy
kbr: PTAL. I will revert the doppler removal (that was done previously) in a separate ...
6 years ago (2014-12-15 19:27:56 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
6 years ago (2014-12-15 20:58:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799023002/20001
6 years ago (2014-12-15 21:31:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/104601)
6 years ago (2014-12-15 21:34:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799023002/40001
6 years ago (2014-12-15 21:41:33 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/104608)
6 years ago (2014-12-15 21:44:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799023002/60001
6 years ago (2014-12-15 23:39:20 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41945)
6 years ago (2014-12-16 01:50:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799023002/60001
6 years ago (2014-12-16 01:54:55 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=187218
6 years ago (2014-12-16 04:12:18 UTC) #24
philipj_slow
Even though this has already landed, can you please send an Intent to Deprecate to ...
6 years ago (2014-12-16 09:15:45 UTC) #25
Raymond Toy
6 years ago (2014-12-16 17:08:16 UTC) #26
Message was sent while issue was closed.
On 2014/12/16 09:15:45, philipj wrote:
> Even though this has already landed, can you please send an Intent to
Deprecate
> to blink-dev? I expect no opposition, but some visibility is good.

Done. I'll be adding a chromestatus entry too.

Powered by Google App Engine
This is Rietveld 408576698