Issue 798913002: Remove FIXME regarding respecting overflow clip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798913002: Remove FIXME regarding respecting overflow clip. (Closed)

Created:
6 years ago by mstensho (USE GERRIT)

Modified:
6 years ago

Reviewers:
chrishtr

CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove FIXME regarding respecting overflow clip. Background: https://bugs.webkit.org/show_bug.cgi?id=91117 This is where ShouldRespectOverflowClip was introduced, and, as the name might suggest, it was only meant to be used for "overflow clip" (RenderObject::hasOverflowClip()), not "clip" (RenderObject::hasClip()). The 'clip' property should always be respected, while we have to ignore overflow clipping sometimes, so that we can composite content not currently within the viewport established by a scrollable container. R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187047

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	Source/core/rendering/RenderLayerClipper.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798913002/1

6 years ago (2014-12-12 17:04:17 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-12 19:20:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187047

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages