Issue 798763005: aw: Fix clearView implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 798763005: aw: Fix clearView implementation (Closed)

Created:
5 years, 11 months ago by boliu

Modified:
5 years, 11 months ago

Reviewers:
boliu

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

aw: Fix clearView implementation The early out was accidentally dropped in a refactor. Add it back here. And also add unit tests for clear view. BUG=448488 Review URL: https://codereview.chromium.org/846323002 Cr-Commit-Position: refs/heads/master@{#311399} (cherry picked from commit 83cbc841cb270e9ccea5a9912c9d9a6135ecb731) TBR=boliu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/06ab47eb8d4e625ea1e41f3961b46e6ba13b13e8

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -12 lines)			Patch
M	android_webview/browser/browser_view_renderer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	android_webview/browser/browser_view_renderer.cc	View	2 chunks	+18 lines, -10 lines	0 comments	Download
M	android_webview/browser/browser_view_renderer_unittest.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	android_webview/browser/test/fake_window.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/browser/test/fake_window.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	android_webview/browser/test/rendering_test.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

boliu

5 years, 11 months ago (2015-01-15 18:05:56 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
06ab47eb8d4e625ea1e41f3961b46e6ba13b13e8 (presubmit successful).