Subzero: Don't store std::string objects inside Variable.

Subzero: Don't store std::string objects inside Variable.

Instead, extend 668a7a333d6ddc3102b5b7c7c07448f6d259113c to include both CfgNode and Variable, keeping a pool of strings in the Cfg.

BUG= none
R=jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9a04c0760fe48d0003ffcc5be13f67ccd924a9a4

[Jim Stichnoth, 2014-12-11 20:48:56]

stichnot@chromium.org changed reviewers:
+ jvoung@chromium.org, kschimpf@google.com

[Jim Stichnoth, 2014-12-11 20:54:00]

This doesn't really save much if any memory from leaking, because short-ish
strings are inlined into the basic std::string object.  But still.

https://codereview.chromium.org/798693003/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (left):

https://codereview.chromium.org/798693003/diff/1/src/PNaClTranslator.cpp#oldc...
src/PNaClTranslator.cpp:1089: class FunctionValuesymtabParser;
Happened to notice that this forward declaration is (no longer) necessary.

[jvoung (off chromium), 2014-12-11 23:39:55]

lgtm

[JF, 2014-12-11 23:45:19]

jfb@chromium.org changed reviewers:
+ jfb@chromium.org

[JF, 2014-12-11 23:45:19]

https://codereview.chromium.org/798693003/diff/20001/src/IceOperand.h
File src/IceOperand.h (left):

https://codereview.chromium.org/798693003/diff/20001/src/IceOperand.h#oldcode500
src/IceOperand.h:500: IceString Name;
That would allow you to remove the ugly default move ctors in your types,
because your classes are now trivially copyable.

[Jim Stichnoth, 2014-12-11 23:51:25]

https://codereview.chromium.org/798693003/diff/20001/src/IceOperand.h
File src/IceOperand.h (left):

https://codereview.chromium.org/798693003/diff/20001/src/IceOperand.h#oldcode500
src/IceOperand.h:500: IceString Name;
On 2014/12/11 23:45:19, JF wrote:
> That would allow you to remove the ugly default move ctors in your types,
> because your classes are now trivially copyable.

Unfortunately, Variable::Live is still there and is a std::vector<>, but that's
next on my list...

[Jim Stichnoth, 2014-12-11 23:51:53]

Committed patchset #2 (id:20001) manually as
9a04c0760fe48d0003ffcc5be13f67ccd924a9a4 (presubmit successful).

[Karl, 2014-12-11 23:51:56]

lgtm