Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 798683003: Rename old Aura TouchSelectionController (Closed)

Created:
6 years ago by mohsen
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename old Aura TouchSelectionController Renamed old Aura TouchSelectionController in ui/base to TouchEditingControllerDeprecated and also the corresponding factory class to TouchEditingControllerFactory. In addition to preventing name conflict with the new unified TouchSelectionController, the names match better with the file name (touch_editing_controller). BUG=399721 Committed: https://crrev.com/2df98ab41dd90307132fe13363332c6fdeffe6a5 Cr-Commit-Position: refs/heads/master@{#308154}

Patch Set 1 #

Patch Set 2 : Minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -46 lines) Patch
M content/browser/web_contents/touch_editable_impl_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 3 chunks +11 lines, -9 lines 0 comments Download
M ui/base/touch/touch_editing_controller.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M ui/views/views_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/views_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/views_touch_selection_controller_factory.h View 1 1 chunk +6 lines, -5 lines 0 comments Download
M ui/views/views_touch_selection_controller_factory_aura.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/views_touch_selection_controller_factory_mac.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mohsen
Please take a look...
6 years ago (2014-12-12 00:07:43 UTC) #2
sadrul
lgtm
6 years ago (2014-12-12 16:54:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798683003/20001
6 years ago (2014-12-12 19:09:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 20:45:35 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 20:46:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2df98ab41dd90307132fe13363332c6fdeffe6a5
Cr-Commit-Position: refs/heads/master@{#308154}

Powered by Google App Engine
This is Rietveld 408576698