Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 798653006: Don't use -O3 with sanitizers. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
earthdok, Alexander Potapenko, inferno, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't use -O3 with sanitizers. BUG=chromium:430614 LOG=n Committed: https://crrev.com/e26627e8da54197fd6a4629e26db1ad9d75eff79 Cr-Commit-Position: refs/heads/master@{#26169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M build/standalone.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M build/toolchain.gypi View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-20 14:17:46 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-20 14:22:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798653006/1
5 years, 11 months ago (2015-01-20 14:42:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 16:07:15 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e26627e8da54197fd6a4629e26db1ad9d75eff79 Cr-Commit-Position: refs/heads/master@{#26169}
5 years, 11 months ago (2015-01-20 16:07:34 UTC) #7
inferno
5 years, 11 months ago (2015-01-20 16:08:00 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698