Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Side by Side Diff: build/toolchain.gypi

Issue 798653006: Don't use -O3 with sanitizers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 13 matching lines...) Expand all
24 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 # Shared definitions for all V8-related targets. 28 # Shared definitions for all V8-related targets.
29 29
30 { 30 {
31 'variables': { 31 'variables': {
32 'msvs_use_common_release': 0, 32 'msvs_use_common_release': 0,
33 'clang%': 0, 33 'clang%': 0,
34 'asan%': 0,
35 'lsan%': 0,
36 'msan%': 0,
37 'tsan%': 0,
38 'ubsan%': 0,
39 'ubsan_vptr%': 0,
34 'v8_target_arch%': '<(target_arch)', 40 'v8_target_arch%': '<(target_arch)',
35 'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")', 41 'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")',
36 # Native Client builds currently use the V8 ARM JIT and 42 # Native Client builds currently use the V8 ARM JIT and
37 # arm/simulator-arm.cc to defer the significant effort required 43 # arm/simulator-arm.cc to defer the significant effort required
38 # for NaCl JIT support. The nacl_target_arch variable provides 44 # for NaCl JIT support. The nacl_target_arch variable provides
39 # the 'true' target arch for places in this file that need it. 45 # the 'true' target arch for places in this file that need it.
40 # TODO(bradchen): get rid of nacl_target_arch when someday 46 # TODO(bradchen): get rid of nacl_target_arch when someday
41 # NaCl V8 builds stop using the ARM simulator 47 # NaCl V8 builds stop using the ARM simulator
42 'nacl_target_arch%': 'none', # must be set externally 48 'nacl_target_arch%': 'none', # must be set externally
43 49
(...skipping 969 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 '-O0', 1019 '-O0',
1014 '-O1', 1020 '-O1',
1015 '-Os', 1021 '-Os',
1016 ], 1022 ],
1017 'cflags': [ 1023 'cflags': [
1018 '-fdata-sections', 1024 '-fdata-sections',
1019 '-ffunction-sections', 1025 '-ffunction-sections',
1020 ], 1026 ],
1021 'conditions': [ 1027 'conditions': [
1022 # TODO(crbug.com/272548): Avoid -O3 in NaCl 1028 # TODO(crbug.com/272548): Avoid -O3 in NaCl
1023 ['nacl_target_arch=="none"', { 1029 # Don't use -O3 with sanitizers.
1030 ['nacl_target_arch=="none" and asan==0 and msan==0 and lsan==0 \
1031 and tsan==0 and ubsan==0 and ubsan_vptr==0', {
1024 'cflags': ['-O3'], 1032 'cflags': ['-O3'],
1025 'cflags!': ['-O2'], 1033 'cflags!': ['-O2'],
1026 }, { 1034 }, {
1027 'cflags': ['-O2'], 1035 'cflags': ['-O2'],
1028 'cflags!': ['-O3'], 1036 'cflags!': ['-O3'],
1029 }], 1037 }],
1030 ], 1038 ],
1031 }], 1039 }],
1032 ['OS=="mac"', { 1040 ['OS=="mac"', {
1033 'xcode_settings': { 1041 'xcode_settings': {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
1098 'cflags!': [ 1106 'cflags!': [
1099 '-Os', 1107 '-Os',
1100 ], 1108 ],
1101 'cflags': [ 1109 'cflags': [
1102 '-fdata-sections', 1110 '-fdata-sections',
1103 '-ffunction-sections', 1111 '-ffunction-sections',
1104 '<(wno_array_bounds)', 1112 '<(wno_array_bounds)',
1105 ], 1113 ],
1106 'conditions': [ 1114 'conditions': [
1107 # TODO(crbug.com/272548): Avoid -O3 in NaCl 1115 # TODO(crbug.com/272548): Avoid -O3 in NaCl
1108 ['nacl_target_arch=="none"', { 1116 # Don't use -O3 with sanitizers.
1117 ['nacl_target_arch=="none" and asan==0 and msan==0 and lsan==0 \
1118 and tsan==0 and ubsan==0 and ubsan_vptr==0', {
1109 'cflags': ['-O3'], 1119 'cflags': ['-O3'],
1110 'cflags!': ['-O2'], 1120 'cflags!': ['-O2'],
1111 }, { 1121 }, {
1112 'cflags': ['-O2'], 1122 'cflags': ['-O2'],
1113 'cflags!': ['-O3'], 1123 'cflags!': ['-O3'],
1114 }], 1124 }],
1115 ], 1125 ],
1116 }], 1126 }],
1117 ['OS=="android"', { 1127 ['OS=="android"', {
1118 'cflags!': [ 1128 'cflags!': [
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
1162 ['v8_enable_slow_dchecks==1', { 1172 ['v8_enable_slow_dchecks==1', {
1163 'defines': [ 1173 'defines': [
1164 'ENABLE_SLOW_DCHECKS', 1174 'ENABLE_SLOW_DCHECKS',
1165 ], 1175 ],
1166 }], 1176 }],
1167 ], # conditions 1177 ], # conditions
1168 }, # Release 1178 }, # Release
1169 }, # configurations 1179 }, # configurations
1170 }, # target_defaults 1180 }, # target_defaults
1171 } 1181 }
OLDNEW
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698