Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 7982004: Merge 95506 - [chromium] ContentLayer's texture updater deleted during paint when compositing tur... (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 95506 - [chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint https://bugs.webkit.org/show_bug.cgi?id=68405 Patch by James Robinson <jamesr@chromium.org>; on 2011-09-19 Reviewed by Kenneth Russell. Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case compositing is turned off halfway through a paint. * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerTextureUpdater::create): * platform/graphics/chromium/ImageLayerChromium.h: * platform/graphics/chromium/LayerTextureUpdater.h: * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterBitmap::create): (WebCore::LayerTextureUpdaterSkPicture::create): * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::TiledLayerChromium::prepareToUpdate): TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4713 lines, -18 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +4695 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/ImageLayerChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerTextureUpdater.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.h View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
7 years, 9 months ago (2011-09-20 17:14:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698