Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: jingle/notifier/base/xmpp_connection_unittest.cc

Issue 798163004: remove some dead visual studio < 2013 code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: no need to implement va_copy on windows anymore Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: jingle/notifier/base/xmpp_connection_unittest.cc
diff --git a/jingle/notifier/base/xmpp_connection_unittest.cc b/jingle/notifier/base/xmpp_connection_unittest.cc
index 682c8d10d843ada4222768ca8a27450687d97feb..2e620920d9ae473d4d7970c772944678f066413c 100644
--- a/jingle/notifier/base/xmpp_connection_unittest.cc
+++ b/jingle/notifier/base/xmpp_connection_unittest.cc
@@ -103,7 +103,7 @@ TEST_F(XmppConnectionTest, CreateDestroy) {
&mock_xmpp_connection_delegate_, NULL);
}
-#if !defined(_MSC_VER) || _MSC_VER < 1700 // http://crbug.com/158570
+#if !defined(_MSC_VER) // http://crbug.com/158570
scottmg 2014/12/13 20:11:02 These are just buggy. :( I guess add 158570 to the
Mostyn Bramley-Moore 2014/12/13 20:22:45 Done.
TEST_F(XmppConnectionTest, ImmediateFailure) {
// ChromeAsyncSocket::Connect() will always return false since we're
// not setting a valid host, but this gets bubbled up as ERROR_NONE
@@ -210,7 +210,7 @@ TEST_F(XmppConnectionTest, MultipleConnect) {
}, "more than once");
}
-#if !defined(_MSC_VER) || _MSC_VER < 1700 // http://crbug.com/158570
+#if !defined(_MSC_VER) // http://crbug.com/158570
TEST_F(XmppConnectionTest, ConnectThenError) {
base::WeakPtr<rtc::Task> weak_ptr;
EXPECT_CALL(mock_xmpp_connection_delegate_, OnConnect(_)).

Powered by Google App Engine
This is Rietveld 408576698