Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 798073003: Update autocomplete dropdown when datalist changes. (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
Reviewers:
tkent
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update autocomplete dropdown when datalist changes. Blink side: https://codereview.chromium.org/799893004 BUG=428790 Committed: https://crrev.com/df5088a6ccb3cb106ddf321dfb9aaa3329700783 Cr-Commit-Position: refs/heads/master@{#308305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Evan Stade
6 years ago (2014-12-13 02:31:57 UTC) #2
Evan Stade
I could not repro the perf regression locally, but it's my hope that the early ...
6 years ago (2014-12-13 02:32:22 UTC) #3
tkent
lgtm
6 years ago (2014-12-15 01:10:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/798073003/1
6 years ago (2014-12-15 01:12:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 02:04:15 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-15 02:04:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df5088a6ccb3cb106ddf321dfb9aaa3329700783
Cr-Commit-Position: refs/heads/master@{#308305}

Powered by Google App Engine
This is Rietveld 408576698