Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 799893004: [Attempt 2] Inform Chrome client of changes to an input's datalist. (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Attempt 2] Inform Chrome client of changes to an input's datalist. This causes Chrome to update any already-visible datalist dropdowns when options are added or removed. Chromium side: https://codereview.chromium.org/798073003/ BUG=428790 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M public/web/WebAutofillClient.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
6 years ago (2014-12-13 02:32:27 UTC) #2
tkent
lgtm
6 years ago (2014-12-15 02:12:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799893004/1
6 years ago (2014-12-15 02:13:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41665)
6 years ago (2014-12-15 04:05:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799893004/1
6 years ago (2014-12-15 04:11:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41694)
6 years ago (2014-12-15 06:10:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799893004/1
6 years ago (2014-12-15 06:13:52 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-15 07:09:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187117

Powered by Google App Engine
This is Rietveld 408576698