PPAPI: Add a warning when URLRequest.SetProperty fails

PPAPI: Add a warning when URLRequest.SetProperty fails

BUG=440079
R=teravest

Committed: https://crrev.com/bdbeb6542f605340b91e1fe828ea2f51517de84e
Cr-Commit-Position: refs/heads/master@{#308158}

[teravest, 2014-12-12 18:39:48]

lgtm

https://codereview.chromium.org/798043003/diff/20001/ppapi/proxy/url_request_...
File ppapi/proxy/url_request_info_resource.cc (right):

https://codereview.chromium.org/798043003/diff/20001/ppapi/proxy/url_request_...
ppapi/proxy/url_request_info_resource.cc:75: "was inappropriate (e.g., the wrong
type of PP_Var).";
It should be easy to see if the passed property is a valid value for that enum,
and then the error messages could be more helpful.

It's not that important, though-- I actually feel that it's a little silly to
log to the console for things like this. Should users expect logging messages to
the JS console every time they pass an invalid value in Pepper?

[teravest, 2014-12-12 18:39:50]

lgtm

lgtm

https://codereview.chromium.org/798043003/diff/20001/ppapi/proxy/url_request_...
File ppapi/proxy/url_request_info_resource.cc (right):

https://codereview.chromium.org/798043003/diff/20001/ppapi/proxy/url_request_...
ppapi/proxy/url_request_info_resource.cc:75: "was inappropriate (e.g., the wrong
type of PP_Var).";
It should be easy to see if the passed property is a valid value for that enum,
and then the error messages could be more helpful.

It's not that important, though-- I actually feel that it's a little silly to
log to the console for things like this. Should users expect logging messages to
the JS console every time they pass an invalid value in Pepper?

[dmichael (off chromium), 2014-12-12 18:50:47]

I think it's rare enough and certain enough to be an error that a log is not too
obtrusive here.

As for getting more fine grained...  I don't want to duplicate bounds checking
here, which by necessity happens in the renderer. (Note that in the error cases
covered here, the renderer will never see it.) I also thought this error would
be useful enough to a developer as-is without forcing us to write and maintain a
lot of special log messages.

[dmichael (off chromium), 2014-12-12 18:50:52]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-12-12 18:51:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798043003/20001

[commit-bot: I haz the power, 2014-12-12 20:58:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-12 20:59:08]

Patchset 2 (id:??) landed as
https://crrev.com/bdbeb6542f605340b91e1fe828ea2f51517de84e
Cr-Commit-Position: refs/heads/master@{#308158}