PPAPI: Add a warning when URLRequest.SetProperty fails

ppapi/proxy/url_request_info_resource.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/url_request_info_resource.h"
 
+#include "base/strings/string_number_conversions.h"
 #include "ppapi/shared_impl/var.h"
 #include "ppapi/thunk/enter.h"
 #include "ppapi/thunk/ppb_file_ref_api.h"
 
 namespace ppapi {
 namespace proxy {
 
 URLRequestInfoResource::URLRequestInfoResource(Connection connection,
                                                PP_Instance instance,
                                                const URLRequestInfoData& data)
@@ skipping 42 matching lines @@
       break;
     case PP_VARTYPE_STRING: {
       StringVar* string = StringVar::FromPPVar(var);
       if (string)
         result = PP_FromBool(SetStringProperty(property, string->value()));
       break;
     }
     default:
       break;
   }
+  if (!result) {
+    std::string error_msg("PPB_URLRequestInfo.SetProperty: Attempted to set a "
+                          "value for PP_URLRequestProperty ");
+    error_msg += base::IntToString(property);
+    error_msg += ", but either this property type is invalid or its parameter "
+                 "was inappropriate (e.g., the wrong type of PP_Var).";

[teravest, 2014/12/12 18:39:49]

It should be easy to see if the passed property is a valid value for that enum,
and then the error messages could be more helpful.

It's not that important, though-- I actually feel that it's a little silly to
log to the console for things like this. Should users expect logging messages to
the JS console every time they pass an invalid value in Pepper?

+    Log(PP_LOGLEVEL_ERROR, error_msg);
+  }
   return result;
 }
 
 PP_Bool URLRequestInfoResource::AppendDataToBody(const void* data,
                                                  uint32_t len) {
   if (len > 0) {
     data_.body.push_back(URLRequestInfoData::BodyItem(
         std::string(static_cast<const char*>(data), len)));
   }
   return PP_TRUE;
@@ skipping 127 matching lines @@
       data_.has_custom_user_agent = true;
       data_.custom_user_agent = value;
       return true;
     default:
       return false;
   }
 }
 
 }  // namespace proxy
 }  // namespace ppapi