Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/nc_cpu_checks.c

Issue 7980021: Speed up x86-64 validator by inlining heavily called routines. Speeds up (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/ncval_reg_sfi/nc_cpu_checks.c
===================================================================
--- src/trusted/validator/x86/ncval_reg_sfi/nc_cpu_checks.c (revision 6742)
+++ src/trusted/validator/x86/ncval_reg_sfi/nc_cpu_checks.c (working copy)
@@ -15,13 +15,14 @@
#include "native_client/src/shared/platform/nacl_log.h"
#include "native_client/src/trusted/validator/x86/nacl_cpuid.h"
-#include "native_client/src/trusted/validator/x86/decoder/nc_inst_iter.h"
#include "native_client/src/trusted/validator/x86/decoder/nc_inst_state.h"
#include "native_client/src/trusted/validator/x86/decoder/nc_inst_state_internal.h"
#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h"
#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_internal.h"
#include "native_client/src/trusted/validator/x86/nc_segment.h"
+#include "native_client/src/trusted/validator/x86/decoder/nc_inst_iter_inl.c"
+
typedef struct NaClCpuCheckState {
/* The standard CPU features. */
CPUFeatures cpu_features;
@@ -171,7 +172,7 @@
}
if (squash_me) {
/* Replace all bytes with the stop instruction. */
- memset(NaClInstIterGetInstMemory(iter), kNaClFullStop,
+ memset(NaClInstIterGetInstMemoryInline(iter), kNaClFullStop,
NaClInstStateLength(inst_state));
}
}
« no previous file with comments | « src/trusted/validator/x86/ncval_reg_sfi/address_sets_inl.c ('k') | src/trusted/validator/x86/ncval_reg_sfi/nc_jumps.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698