Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: src/trusted/validator/x86/decoder/ncopcode_desc_inl.c

Issue 7980021: Speed up x86-64 validator by inlining heavily called routines. Speeds up (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/decoder/ncopcode_desc_inl.c
===================================================================
--- src/trusted/validator/x86/decoder/ncopcode_desc_inl.c (revision 0)
+++ src/trusted/validator/x86/decoder/ncopcode_desc_inl.c (revision 0)
@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) 2011 The Native Client Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+/*
+ * ncopcode_desc_inl.c - Holds inline routines for commonly used (simple)
+ * functions in ncopcode_desc.h. Used to speed up code. Inlined routines
+ * correspond to the following functions in ncopcode_desc.h, but with
+ * an 'Inline' suffix:
+ *
+ * NaClGetInstNumberOperands
+ * NaClGetInstOperand
+ */
+#ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_DECODER_NCOPCODE_DESC_INL_H_
+#define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_DECODER_NCOPCODE_DESC_INL_H_
+
+#include <assert.h>
+#include "native_client/src/trusted/validator/x86/decoder/ncopcode_desc.h"
+#include "native_client/src/trusted/validator/x86/decoder/nc_decode_tables.h"
+
+/* Returns the number of logical operands an instruction has. That is,
+ * returns field num_operands unless the first operand is
+ * a special encoding that extends the opcode.
+ */
+static uint8_t NaClGetInstNumberOperandsInline(const NaClInst* inst) {
+ return inst->num_operands;
+}
+
+/* Returns the indexed logical operand for the instruction. That is,
+ * returns the index-th operand unless the first operand is
+ * a special encoding that extends the opcode. In the latter
+ * case, the (index+1)-th operand is returned.
+ */
+static const INLINE NaClOp* NaClGetInstOperandInline(
+ const NaClDecodeTables* tables,
+ const NaClInst* inst, uint8_t index) {
+ assert(index < inst->num_operands);
+ return &tables->operands_table[inst->operands_offset + index];
+}
+
+#endif /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_DECODER_NCOPCODE_DESC_INL_H_ */
Property changes on: src/trusted/validator/x86/decoder/ncopcode_desc_inl.c
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « src/trusted/validator/x86/decoder/ncopcode_desc.c ('k') | src/trusted/validator/x86/decoder/ncopcode_desc_verbose.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698