Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 797923002: Remove comments from the PNG callbacks (Closed)

Created:
6 years ago by Noel Gordon
Modified:
6 years ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove comments from the PNG callbacks The comments and the callback routine names repeat themselves. Retain the valuable things (the compiler decides the matter). Also choose names that do help describe pngRowAvailable() but without introducing concepts like "interlacing" so early in the code: use row and state instead. BUG=439655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187022

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M Source/platform/image-decoders/png/PNGImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Noel Gordon
6 years ago (2014-12-12 05:42:56 UTC) #2
Noel Gordon
Last one in this series, btw.
6 years ago (2014-12-12 05:48:12 UTC) #3
Ken Russell (switch to Gerrit)
lgtm
6 years ago (2014-12-12 06:10:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797923002/20001
6 years ago (2014-12-12 07:57:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/20015)
6 years ago (2014-12-12 08:13:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797923002/20001
6 years ago (2014-12-12 09:20:19 UTC) #13
Noel Gordon
Tree redness dealt with on https://codereview.chromium.org/797183002
6 years ago (2014-12-12 09:20:46 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/38337)
6 years ago (2014-12-12 10:59:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797923002/20001
6 years ago (2014-12-12 12:27:08 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-12 13:39:56 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187022

Powered by Google App Engine
This is Rietveld 408576698