Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 797183002: Revert of Updating OTS repo from https://github.com/khaledhosny/ots.git (Closed)

Created:
6 years ago by bashi
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Updating OTS repo from https://github.com/khaledhosny/ots.git (patchset #4 id:60001 of https://codereview.chromium.org/775893002/) Reason for revert: Broke bots Original issue's description: > The original CL is https://codereview.chromium.org/658573004 > > Updating with to new OTS repo from https://github.com/khaledhosny/ots.git > Hash tag imported: c24a839b1c66c4de09e58fabaacb82bf3bd692a4 > > Some important differences between new and old version of OTS: > 1. Support for MATH table > 2. Implementation changes related to new WOFF 2.0 > 3. Bug fixes related to OTF tables (GDEF, GSUB etc) parsing > 4. Accept platform 0 encoding 1 cmap subtables > 5. Allow fonts with CMAP format-12 or format-13 table > > A dummy version of EnableWOFF() is added to get Blink compiled. > After the following CL is landed in Blink, it'll be removed. > Blink CL: https://codereview.chromium.org/774253008 > > # TODO(jschuh): 4267, 4334 are 64-bit cleanness issue. http://crbug.com/167187 > > # TODO(h.joshi) : Make 4800 go away. <https://github.com/khaledhosny/ots/issues/44>;. > Currently patch to github (https://github.com/himanshuispresent/ots/commit/02f724f758ddb1cb264cc0259ffd5ef1cafa164a) is > submitted so that taking OTS repository to Chromium should not cause issue on Windows bots. > > TEST: Blink layout tests: fast/css/font-face* > BUG=339857 > > Committed: https://crrev.com/3b6cd2d4bf9e0b4a9311343a2997ef9363530b14 > Cr-Commit-Position: refs/heads/master@{#308054} TBR=jshin@chromium.org,behdad@chromium.org,h.joshi@samsung.com NOTREECHECKS=true NOTRY=true BUG=339857 Committed: https://crrev.com/a72cd11114dbe2c2f35dec9b99298ca66473b08f Cr-Commit-Position: refs/heads/master@{#308061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18134 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/ots/.gitignore View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/ots/.gitmodules View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/ots/BUILD.gn View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/ots/INSTALL View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/ots/LICENSE View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/ots/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/ots/README View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/ots/README.chromium View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/ots/docs/DesignDoc.md View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/ots/docs/HowToTest.md View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/ots/gyp_ots View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/ots/include/opentype-sanitiser.h View 1 chunk +0 lines, -231 lines 0 comments Download
D third_party/ots/include/ots-memory-stream.h View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/ots/ots.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/ots/ots-common.gypi View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/ots/ots-standalone.gyp View 1 chunk +0 lines, -256 lines 0 comments Download
D third_party/ots/src/cff.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/ots/src/cff.cc View 1 chunk +0 lines, -1041 lines 0 comments Download
D third_party/ots/src/cff_type2_charstring.h View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/ots/src/cff_type2_charstring.cc View 1 chunk +0 lines, -914 lines 0 comments Download
D third_party/ots/src/cmap.h View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/ots/src/cmap.cc View 1 chunk +0 lines, -1106 lines 0 comments Download
D third_party/ots/src/cvt.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/ots/src/cvt.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/ots/src/fpgm.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/ots/src/fpgm.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/ots/src/gasp.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/ots/src/gasp.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/ots/src/gdef.h View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/ots/src/gdef.cc View 1 chunk +0 lines, -388 lines 0 comments Download
D third_party/ots/src/glyf.h View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/ots/src/glyf.cc View 1 chunk +0 lines, -298 lines 0 comments Download
D third_party/ots/src/gpos.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/ots/src/gpos.cc View 1 chunk +0 lines, -828 lines 0 comments Download
D third_party/ots/src/gsub.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/ots/src/gsub.cc View 1 chunk +0 lines, -685 lines 0 comments Download
D third_party/ots/src/hdmx.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/ots/src/hdmx.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D third_party/ots/src/head.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/ots/src/head.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/ots/src/hhea.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/ots/src/hhea.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/ots/src/hmtx.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/ots/src/hmtx.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/ots/src/kern.h View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/ots/src/kern.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D third_party/ots/src/layout.h View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/ots/src/layout.cc View 1 chunk +0 lines, -1511 lines 0 comments Download
D third_party/ots/src/loca.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/ots/src/loca.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/ots/src/ltsh.h View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/ots/src/ltsh.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/ots/src/math.cc View 1 chunk +0 lines, -609 lines 0 comments Download
D third_party/ots/src/math_.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/ots/src/maxp.h View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/ots/src/maxp.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/ots/src/metrics.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/ots/src/metrics.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D third_party/ots/src/name.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/ots/src/name.cc View 1 chunk +0 lines, -340 lines 0 comments Download
D third_party/ots/src/os2.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/ots/src/os2.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D third_party/ots/src/ots.h View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/ots/src/ots.cc View 1 chunk +0 lines, -824 lines 0 comments Download
D third_party/ots/src/post.h View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/ots/src/post.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D third_party/ots/src/prep.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/ots/src/prep.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/ots/src/vdmx.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/ots/src/vdmx.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D third_party/ots/src/vhea.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/ots/src/vhea.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/ots/src/vmtx.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/ots/src/vmtx.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/ots/src/vorg.h View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/ots/src/vorg.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/ots/src/woff2.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/ots/src/woff2.cc View 1 chunk +0 lines, -991 lines 0 comments Download
D third_party/ots/test/BLACKLIST.txt View 1 chunk +0 lines, -124 lines 0 comments Download
D third_party/ots/test/README View 1 chunk +0 lines, -243 lines 0 comments Download
D third_party/ots/test/cff_type2_charstring_test.cc View 1 chunk +0 lines, -1584 lines 0 comments Download
D third_party/ots/test/file-stream.h View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/ots/test/idempotent.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D third_party/ots/test/layout_common_table_test.cc View 1 chunk +0 lines, -761 lines 0 comments Download
D third_party/ots/test/ot-sanitise.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/ots/test/perf.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/ots/test/side-by-side.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D third_party/ots/test/table_dependencies_test.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/ots/test/test_malicious_fonts.sh View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/ots/test/test_unmalicious_fonts.sh View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/ots/test/validator-checker.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/ots/third_party/brotli.gyp View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/ots/tools/ttf-checksum.py View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bashi
Created Revert of Updating OTS repo from https://github.com/khaledhosny/ots.git
6 years ago (2014-12-12 08:37:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797183002/1
6 years ago (2014-12-12 08:37:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 08:38:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a72cd11114dbe2c2f35dec9b99298ca66473b08f Cr-Commit-Position: refs/heads/master@{#308061}
6 years ago (2014-12-12 08:39:31 UTC) #4
Noel Gordon
6 years ago (2014-12-12 09:25:27 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698