Issue 797903003: [turbofan] Various cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 797903003: [turbofan] Various cleanups. (Closed)

Created:
6 years ago by Benedikt Meurer

Modified:
6 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Various cleanups. - Decouple JSBuiltinReducer from JSTypedLowering. - Unify JSTypedLowering::ReduceJSToXXX() lowering. - Cleanup several includes and forward declarations. - Unify helper methods. TEST=cctest R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/4c583fee267e6759ebd6afb008c5546a1dab7bba

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+295 lines, -212 lines)			Patch
M	src/compiler/graph.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	src/compiler/js-builtin-reducer.h	View	2 chunks	+15 lines, -13 lines	0 comments	Download
M	src/compiler/js-builtin-reducer.cc	View	3 chunks	+18 lines, -0 lines	0 comments	Download
M	src/compiler/js-graph.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/compiler/js-typed-lowering.h	View	2 chunks	+21 lines, -18 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View	19 chunks	+227 lines, -172 lines	0 comments	Download
M	src/compiler/pipeline.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/types.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

6 years ago (2014-12-12 07:44:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4c583fee267e6759ebd6afb008c5546a1dab7bba (presubmit successful).