Issue 7979030: Make it easier to remove path-specific whitelist entries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7979030: Make it easier to remove path-specific whitelist entries (Closed)

Created:
9 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 3 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make it easier to remove path-specific whitelist entries by adding a flag to ignore path-specific suppression. This will allow me to file bugs about current suppressions and just say 'run checklicenses.py --ignore-suppressions some/path to repro' BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102292

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	tools/checklicenses/checklicenses.py	View		3 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 3 months ago (2011-09-22 14:57:31 UTC) #2

In your description you say no-suppressions, but in the code it looks like it's
ignore-suppressions.  Please choose one. ;)

LGTM

Expand Messages | Collapse Messages