Chromium Code Reviews
Help | Chromium Project | Sign in
(59)

Issue 7979030: Make it easier to remove path-specific whitelist entries (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Paweł Hajdan Jr.
Modified:
2 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Make it easier to remove path-specific whitelist entries
by adding a flag to ignore path-specific suppression.

This will allow me to file bugs about current suppressions
and just say 'run checklicenses.py --ignore-suppressions some/path to repro'

BUG=28291
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Lint Patch
M tools/checklicenses/checklicenses.py View 3 chunks +14 lines, -6 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Paweł Hajdan Jr.
2 years, 7 months ago #1
Evan Martin
2 years, 7 months ago #2
In your description you say no-suppressions, but in the code it looks like it's
ignore-suppressions.  Please choose one. ;)

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6