Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 797813003: Fix errors causing GN fail during processing remoting .gni file. (Closed)

Created:
6 years ago by Slava Chigrin
Modified:
6 years ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix errors causing GN fail during processing remoting .gni file. Committed: https://crrev.com/e74f9bf82535e36339d80b6ed57eac2a4eef3ee9 Cr-Commit-Position: refs/heads/master@{#308474}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M remoting/remoting_version.gni View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Slava Chigrin
https://codereview.chromium.org/797813003/diff/1/remoting/remoting_version.gni File remoting/remoting_version.gni (left): https://codereview.chromium.org/797813003/diff/1/remoting/remoting_version.gni#oldcode76 remoting/remoting_version.gni:76: "value", Seems, there was a problem handling values, containing ...
6 years ago (2014-12-15 19:25:08 UTC) #2
rmsousa
lgtm
6 years ago (2014-12-15 21:49:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797813003/1
6 years ago (2014-12-15 23:31:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 00:35:22 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-16 00:37:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e74f9bf82535e36339d80b6ed57eac2a4eef3ee9
Cr-Commit-Position: refs/heads/master@{#308474}

Powered by Google App Engine
This is Rietveld 408576698