remoting/remoting_version.gni - Issue 797813003: Fix errors causing GN fail during processing remoting .gni file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/remoting_version.gni

Issue 797813003: Fix errors causing GN fail during processing remoting .gni file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 _version_py_abspath = "//build/util/version.py"	5 _version_py_abspath = "//build/util/version.py"

6 _remoting_version_abspath = "//remoting/VERSION"	6 _remoting_version_abspath = "//remoting/VERSION"

7 _chrome_version_abspath = "//chrome/VERSION"	7 _chrome_version_abspath = "//chrome/VERSION"

8 if (is_chrome_branded) {	8 if (is_chrome_branded) {

9 _remoting_branding_abspath = "//remoting/branding_Chrome"	9 _remoting_branding_abspath = "//remoting/branding_Chrome"

10 } else {	10 } else {

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 ],	66 ],

67 "value",	67 "value",

68 _script_deps)	68 _script_deps)

69	69

70 prefpane_bundle_name = exec_script(_version_py_abspath,	70 prefpane_bundle_name = exec_script(_version_py_abspath,

71 [	71 [

72 "-f",	72 "-f",

73 _remoting_branding_path,	73 _remoting_branding_path,

74 "-t \"@MAC_PREFPANE_BUNDLE_NAME@\"",	74 "-t \"@MAC_PREFPANE_BUNDLE_NAME@\"",

75 ],	75 ],

76 "value",	76 "string",
Slava Chigrin 2014/12/15 19:25:08 Seems, there was a problem handling values, contai Seems, there was a problem handling values, containing dots (at least on Windows). Here string was Chromoting.prefPane, and on later script invokation - ChromotingHost.bundle
77 _script_deps)	77 _script_deps)

78	78

79 host_bundle_name = exec_script(_version_py_abspath,	79 host_bundle_name = exec_script(_version_py_abspath,

80 [	80 [

81 "-f",	81 "-f",

82 _remoting_branding_path,	82 _remoting_branding_path,

83 "-t \"@MAC_HOST_BUNDLE_NAME@\"",	83 "-t \"@MAC_HOST_BUNDLE_NAME@\"",

84 ],	84 ],

85 "value",	85 "string",

86 _script_deps)	86 _script_deps)

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »