[Hotword] Hotword and Audio History settings should reflect sync sign in

[Hotword] Hotword and Audio History settings should reflect sync sign in
setting.

The functions for showing hotwording and showing the audio history state
now take into account the sign in state and correctly update when the
sign in state changes.

BUG=441419, 435637
Committed: https://crrev.com/7ca0f28d650487e360d40192cf877973a054bdbf
Cr-Commit-Position: refs/heads/master@{#308194}

[rpetterson, 2014-12-11 20:19:29]

rlp@chromium.org changed reviewers:
+ dbeam@chromium.org

[rpetterson, 2014-12-11 20:19:29]

Thank you!

[Dan Beam, 2014-12-11 22:16:53]

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/browser_options.js:1234: * @param {string}
stateText Text describing current audio history state.
labelText or sectionLabel (it doesn't matter to this code *what* the string is)

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1556: // displayed.
Hide all hotwording and re-display properly.
indent off

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1698: function_name =
"BrowserOptions.showHotwordSection";
why isn't this using setHotwordSectionVisible?

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1712:
base::ASCIIToUTF16(user_display_name));
indent off

[rpetterson, 2014-12-12 19:52:47]

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/browser_options.js:1234: * @param {string}
stateText Text describing current audio history state.
On 2014/12/11 22:16:53, Dan Beam wrote:
> labelText or sectionLabel (it doesn't matter to this code *what* the string
is)

Done.

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1556: // displayed.
Hide all hotwording and re-display properly.
On 2014/12/11 22:16:53, Dan Beam wrote:
> indent off

Done.

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1698: function_name =
"BrowserOptions.showHotwordSection";
On 2014/12/11 22:16:53, Dan Beam wrote:
> why isn't this using setHotwordSectionVisible?

setHotwordSectionVisible is a catch all for all the different possible hotword
sections. These are showing the individual sections. This particular one should
be something like showV1HotwordSection although it will go away once M41 hits
stable. I agree this is a confusing set of names. I've updated
setHotwordSectionVisible to be setAllHotwordSectionsVisible so hopefully that
makes it clearer.

https://codereview.chromium.org/797763002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1712:
base::ASCIIToUTF16(user_display_name));
On 2014/12/11 22:16:53, Dan Beam wrote:
> indent off

Done.

[Dan Beam, 2014-12-12 20:06:33]

lgtm

https://codereview.chromium.org/797763002/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/797763002/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:547:
chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
nit: indent off

https://codereview.chromium.org/797763002/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1710: std::string
user_display_name = signin->GetAuthenticatedUsername();
DCHECK(!user_display_name.empty());

[rpetterson, 2014-12-12 20:10:38]

https://codereview.chromium.org/797763002/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/797763002/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:547:
chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
On 2014/12/12 20:06:32, Dan Beam wrote:
> nit: indent off

Done.

https://codereview.chromium.org/797763002/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1710: std::string
user_display_name = signin->GetAuthenticatedUsername();
On 2014/12/12 20:06:32, Dan Beam wrote:
> DCHECK(!user_display_name.empty());

Done.

[rpetterson, 2014-12-12 22:24:37]

The CQ bit was checked by rlp@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:26:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797763002/60001

[commit-bot: I haz the power, 2014-12-12 23:49:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-12 23:50:10]

Patchset 4 (id:??) landed as
https://crrev.com/7ca0f28d650487e360d40192cf877973a054bdbf
Cr-Commit-Position: refs/heads/master@{#308194}