chrome/browser/resources/options/browser_options.js - Issue 797763002: [Hotword] Hotword and Audio History settings should reflect sync sign in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 797763002: [Hotword] Hotword and Audio History settings should reflect sync sign in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit and DCHECK Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/browser_options.js

diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js

index 1b36e91a2f81fb48d24f2b7212e2cdbb4754ded8..49ae2b9ce844e9a66b7cdaf4a8ad63fd3a7fc2ba 100644

--- a/chrome/browser/resources/options/browser_options.js

+++ b/chrome/browser/resources/options/browser_options.js

@@ -1202,7 +1202,7 @@ cr.define('options', function() {

* @param {boolean} visible Whether to show hotword sections.

* @private

- setHotwordSectionVisible_: function(visible) {

+ setAllHotwordSectionsVisible_: function(visible) {

$('hotword-search').hidden = !visible;

$('hotword-always-on-search').hidden = !visible;

$('hotword-no-dsp-search').hidden = !visible;

@@ -1231,10 +1231,12 @@ cr.define('options', function() {

/**

* Activates the Audio History section of the Settings page.

* @param {boolean} alwaysOn Whether always-on hotwording is available.

+ * @param {string} labelText Text describing current audio history state.

* @private

- showAudioHistorySection_: function(alwaysOn) {

+ showAudioHistorySection_: function(alwaysOn, labelText) {

$('audio-history').hidden = false;

+ $('audio-history-label').textContent = labelText;

$('audio-history-always-on-description').hidden = !alwaysOn;

@@ -2127,7 +2129,7 @@ cr.define('options', function() {

'setNativeThemeButtonEnabled',

'setNetworkPredictionValue',

'setHighContrastCheckboxState',

- 'setHotwordSectionVisible',

+ 'setAllHotwordSectionsVisible',

'setMetricsReportingCheckboxState',

'setMetricsReportingSettingVisibility',

'setProfilesInfo',