Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797693003: Add a histogram for session resumption version mismatches. (Closed)

Created:
6 years ago by davidben
Modified:
6 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a histogram for session resumption version mismatches. BUG=441456 Committed: https://crrev.com/85574eb3d757524df7d7c747ccb8160e096b65ae Cr-Commit-Position: refs/heads/master@{#308040}

Patch Set 1 #

Patch Set 2 : record it when the connection succeeded #

Total comments: 2

Patch Set 3 : rsleevi comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
davidben
6 years ago (2014-12-11 22:10:57 UTC) #5
Ryan Sleevi
lgtm lgtm https://codereview.chromium.org/797693003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/797693003/diff/20001/tools/metrics/histograms/histograms.xml#newcode18993 tools/metrics/histograms/histograms.xml:18993: + For each SSL connection which resumed ...
6 years ago (2014-12-11 22:20:59 UTC) #6
davidben
+isherman for histogram OWNERS https://codereview.chromium.org/797693003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/797693003/diff/20001/tools/metrics/histograms/histograms.xml#newcode18993 tools/metrics/histograms/histograms.xml:18993: + For each SSL connection ...
6 years ago (2014-12-11 22:35:40 UTC) #8
Ilya Sherman
LGTM
6 years ago (2014-12-11 23:09:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797693003/40001
6 years ago (2014-12-11 23:25:19 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 03:02:06 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-12 03:02:48 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/85574eb3d757524df7d7c747ccb8160e096b65ae
Cr-Commit-Position: refs/heads/master@{#308040}

Powered by Google App Engine
This is Rietveld 408576698