Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 797693003: Add a histogram for session resumption version mismatches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rsleevi comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index 4e86c055932ed7517600625db0179d13ee720029..b5a9472d8009522e2281e6c56eb1239a86ff7fac 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -1131,9 +1131,18 @@ int SSLClientSocketOpenSSL::DoVerifyCertComplete(int result) {
}
}
- if (result == OK)
+ if (result == OK) {
RecordConnectionTypeMetrics(GetNetSSLVersion(ssl_));
+ if (SSL_session_reused(ssl_)) {
+ // Record whether or not the server tried to resume a session for a
+ // different version. See https://crbug.com/441456.
+ UMA_HISTOGRAM_BOOLEAN(
+ "Net.SSLSessionVersionMatch",
+ SSL_version(ssl_) == SSL_get_session(ssl_)->ssl_version);
+ }
+ }
+
const CertStatus cert_status = server_cert_verify_result_.cert_status;
if (transport_security_state_ &&
(result == OK ||
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698