Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 797623002: When reading the map from a live object, use a barrier load (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

When reading the map from a live object, use a barrier load It could happen that we shrink a live object on the main thread (e.g. MigrateFastToSlow) while we're sweeping the same page. The main thread first creates a filler object that the release-stores the new map. Therefore it's important to barrier load the map word of live objects from the sweeper thread. BUG=none R=ulan@chromium.org,hpayer@chromium.org LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-11 14:46:57 UTC) #1
ulan
lgtm "The main thread first creates a filler object" Did you mean "sweeper thread"?
6 years ago (2014-12-11 14:51:34 UTC) #2
jochen (gone - plz use gerrit)
On 2014/12/11 at 14:51:34, ulan wrote: > lgtm > > "The main thread first creates ...
6 years ago (2014-12-11 14:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797623002/1
6 years ago (2014-12-11 14:58:34 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 15:25:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698