src/heap/mark-compact.cc - Issue 797623002: When reading the map from a live object, use a barrier load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/mark-compact.cc

Issue 797623002: When reading the map from a live object, use a barrier load (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/mark-compact.cc

diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc

index b2f067bc9049961d337c832437201c35cdf576d3..85afd16f0ba13a7c834cba9c55d4533730ffbc5b 100644

--- a/src/heap/mark-compact.cc

+++ b/src/heap/mark-compact.cc

@@ -3243,7 +3243,7 @@ static int Sweep(PagedSpace* space, FreeList* free_list, Page* p,

}

HeapObject* live_object = HeapObject::FromAddress(free_end);

DCHECK(Marking::IsBlack(Marking::MarkBitFrom(live_object)));

- Map* map = live_object->map();

+ Map* map = live_object->synchronized_map();

int size = live_object->SizeFromMap(map);

if (sweeping_mode == SWEEP_AND_VISIT_LIVE_OBJECTS) {

live_object->IterateBody(map->instance_type(), size, v);

« no previous file with comments | « no previous file | no next file » | no next file with comments »