Issue 797523002: Improve default email address for my_reviews.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 797523002: Improve default email address for my_reviews.py (Closed)

Created:
6 years ago by Sam Clegg

Modified:
6 years ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

More Reviews

Description

Improve default email address for my_reviews.py Also, fix assertion that fires if all the reviews are on the same day (first_day == last_day) Also, don't print backtrace if no arguments at all are specified. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293351

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
	M	my_reviews.py	View		4 chunks	+16 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797523002/1

6 years ago (2014-12-11 17:13:28 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-11 17:15:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293351

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages