Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797503007: Auto-generate v8 version based on tags. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Auto-generate v8 version based on tags. BUG=chromium:446166 LOG=y Committed: https://crrev.com/b301b85be895c6fcd1edfe2fd1e60b5abd0ac64d Cr-Commit-Position: refs/heads/master@{#26062}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix old review comments. #

Patch Set 3 : Fix android build #

Patch Set 4 : Sorting #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -16 lines) Patch
M BUILD.gn View 1 2 3 4 4 chunks +21 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 4 chunks +35 lines, -1 line 0 comments Download
M tools/push-to-trunk/generate_version.py View 1 2 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/797503007/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/797503007/diff/1/BUILD.gn#newcode966 BUILD.gn:966: "$target_gen_dir/version.cc", I'm not so happy about the sorting. ...
5 years, 11 months ago (2015-01-07 14:01:16 UTC) #2
Jakob Kummerow
v8.gyp and script LGTM. I'm not qualified to approve GN changes. https://codereview.chromium.org/797503007/diff/1/BUILD.gn File BUILD.gn (right): ...
5 years, 11 months ago (2015-01-07 16:21:00 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-07 16:29:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797503007/60001
5 years, 11 months ago (2015-01-14 15:52:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/2139) v8_win_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/2277)
5 years, 11 months ago (2015-01-14 15:53:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797503007/80001
5 years, 11 months ago (2015-01-14 16:02:49 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-14 16:43:32 UTC) #11
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/b301b85be895c6fcd1edfe2fd1e60b5abd0ac64d Cr-Commit-Position: refs/heads/master@{#26062}
5 years, 11 months ago (2015-01-14 16:43:51 UTC) #12
Michael Achenbach
5 years, 11 months ago (2015-01-15 08:00:22 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/850263002/ by machenbach@chromium.org.

The reason for reverting is: Blocks roll on android_aosp:
https://codereview.chromium.org/851953005/.

Powered by Google App Engine
This is Rietveld 408576698