Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/gyp/v8.gyp

Issue 797503007: Auto-generate v8 version based on tags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | tools/push-to-trunk/generate_version.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 2472b333539eaf3a4d4a976c21bd981ef562e541..76a2a736ede43050760d7fdd201f88f9ebf352cc 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -336,6 +336,34 @@
],
},
{
+ 'target_name': 'v8_version',
+ 'type': 'none',
+ 'conditions': [
+ ['want_separate_host_toolset==1', {
+ 'toolsets': ['host'],
+ }, {
+ 'toolsets': ['target'],
+ }],
+ ],
+ 'actions': [
+ {
+ 'action_name': 'generate_v8_version',
+ 'inputs': [
+ '../../tools/push-to-trunk/generate_version.py',
+ '../../src/version.cc',
+ ],
+ 'outputs': [
+ '<(SHARED_INTERMEDIATE_DIR)/version.cc',
+ ],
+ 'action': [
+ 'python',
+ '../../tools/push-to-trunk/generate_version.py',
+ '<(SHARED_INTERMEDIATE_DIR)/version.cc',
+ ],
+ },
+ ],
+ },
+ {
'target_name': 'v8_base',
'type': 'static_library',
'dependencies': [
@@ -348,6 +376,7 @@
'../..',
],
'sources': [ ### gcmole(all) ###
+ '<(SHARED_INTERMEDIATE_DIR)/version.cc',
'../../src/accessors.cc',
'../../src/accessors.h',
'../../src/allocation.cc',
@@ -886,7 +915,6 @@
'../../src/variables.cc',
'../../src/variables.h',
'../../src/vector.h',
- '../../src/version.cc',
'../../src/version.h',
'../../src/vm-state-inl.h',
'../../src/vm-state.h',
@@ -898,8 +926,14 @@
],
'conditions': [
['want_separate_host_toolset==1', {
+ 'dependencies': [
+ 'v8_version#host',
+ ],
'toolsets': ['host', 'target'],
}, {
+ 'dependencies': [
+ 'v8_version',
+ ],
'toolsets': ['target'],
}],
['v8_target_arch=="arm"', {
« no previous file with comments | « BUILD.gn ('k') | tools/push-to-trunk/generate_version.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698