Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 797503006: Revert "Don't show the shadow for maximized/fullscreen window" (Closed)

Created:
6 years ago by Reilly Grant (use Gerrit)
Modified:
6 years ago
Reviewers:
Lei Zhang, oshima, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Don't show the shadow for maximized/fullscreen window" This reverts commit deecdafa38a9effc737acde28e82a32cc527a1b5. BUG= TBR=oshima@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7f50639d2aa1f49bb97e80296ad3d2e662016fd8 Cr-Commit-Position: refs/heads/master@{#309288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M ui/wm/core/shadow_controller.cc View 3 chunks +1 line, -10 lines 0 comments Download
M ui/wm/core/shadow_controller_unittest.cc View 2 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797503006/1
6 years ago (2014-12-19 23:22:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 23:24:10 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7f50639d2aa1f49bb97e80296ad3d2e662016fd8 Cr-Commit-Position: refs/heads/master@{#309288}
6 years ago (2014-12-19 23:24:51 UTC) #5
Lei Zhang
6 years ago (2014-12-19 23:25:46 UTC) #7
Message was sent while issue was closed.
https://chromium.googlesource.com/chromium/src/+/933d4da4fb425cb57480445f21c6...
got reverted, so we had to revert here too.

Powered by Google App Engine
This is Rietveld 408576698