Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797493002: Eliminate the launcher speech recognizer's dependency on the start page WebContents. (Closed)

Created:
6 years ago by Anand Mistry (off Chromium)
Modified:
6 years ago
Reviewers:
calamity, Jun Mukai
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate the launcher speech recognizer's dependency on the start page WebContents. This affects the speech recognition with V2 hotwording enabled. Committed: https://crrev.com/0e893e92f2624e602d79866ee7bafed66a629df8 Cr-Commit-Position: refs/heads/master@{#308304}

Patch Set 1 #

Patch Set 2 : Change invalid PID. #

Patch Set 3 : Fix test. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -44 lines) Patch
M chrome/browser/ui/app_list/speech_recognizer.cc View 1 2 3 6 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/ui/app_list/speech_recognizer_browsertest.cc View 1 2 3 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/speech_recognizer_delegate.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 2 3 3 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
calamity: Please review in general. mukai: Added as reviewer due to historical context.
6 years ago (2014-12-11 02:21:44 UTC) #2
Anand Mistry (off Chromium)
Oops. Switching to the "real" mukai.
6 years ago (2014-12-11 02:23:17 UTC) #4
Jun Mukai
lgtm
6 years ago (2014-12-11 18:26:19 UTC) #5
calamity
lgtm
6 years ago (2014-12-12 04:09:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797493002/60001
6 years ago (2014-12-15 00:04:38 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 00:56:06 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-15 00:56:52 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0e893e92f2624e602d79866ee7bafed66a629df8
Cr-Commit-Position: refs/heads/master@{#308304}

Powered by Google App Engine
This is Rietveld 408576698