chrome/browser/ui/app_list/speech_recognizer_delegate.h - Issue 797493002: Eliminate the launcher speech recognizer's dependency on the start page WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/speech_recognizer_delegate.h

Issue 797493002: Eliminate the launcher speech recognizer's dependency on the start page WebContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/speech_recognizer_browsertest.cc ('k') | chrome/browser/ui/app_list/start_page_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/speech_recognizer_delegate.h

diff --git a/chrome/browser/ui/app_list/speech_recognizer_delegate.h b/chrome/browser/ui/app_list/speech_recognizer_delegate.h

index 2ce420613af6d4adee7572bebe8c38681e69d835..100c96bf2f05eaa7504088b663daf01d4c823e09 100644

--- a/chrome/browser/ui/app_list/speech_recognizer_delegate.h

+++ b/chrome/browser/ui/app_list/speech_recognizer_delegate.h

@@ -33,11 +33,6 @@ class SpeechRecognizerDelegate {

virtual void OnSpeechRecognitionStateChanged(

SpeechRecognitionState new_state) = 0;

- // Return a WebContents that is whitelisted to use the speech recognizer.

- // TODO(amistry): This is an implementation detail that shouldn't be

- // necessary. Somehow, eliminate this dependency.

- virtual content::WebContents* GetSpeechContents() = 0;

// Get the OAuth2 scope and token to pass to the speech recognizer. Does not

// modify the arguments if no auth token is available or allowed.

virtual void GetSpeechAuthParameters(std::string* auth_scope,

« no previous file with comments | « chrome/browser/ui/app_list/speech_recognizer_browsertest.cc ('k') | chrome/browser/ui/app_list/start_page_service.h » ('j') | no next file with comments »