Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 797483002: ozone: evdev: Populate keyboard list on DeviceDataManager (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Populate keyboard list on DeviceDataManager Add a method to EventDeviceInfo to determine if the device has a keyboard on it based on the key bitmap. We'll require the first 31 keys to be considered a keyboard; this is compatible with udev. TEST=chrome on link_freon & rush_ryu BUG=437539 Committed: https://crrev.com/9ad06b87192fa8789c1e8fc6fdd21423883cd2d9 Cr-Commit-Position: refs/heads/master@{#308237}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
M ui/events/ozone/evdev/event_converter_evdev.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.h View 4 chunks +6 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_device_info.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_device_info.cc View 1 chunk +13 lines, -0 lines 1 comment Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 5 chunks +28 lines, -14 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
spang
depends on https://codereview.chromium.org/790153005/
6 years ago (2014-12-11 02:14:11 UTC) #2
sadrul
lgtm https://codereview.chromium.org/797483002/diff/1/ui/events/ozone/evdev/event_device_info.cc File ui/events/ozone/evdev/event_device_info.cc (right): https://codereview.chromium.org/797483002/diff/1/ui/events/ozone/evdev/event_device_info.cc#newcode242 ui/events/ozone/evdev/event_device_info.cc:242: for (int key = KEY_ESC; key <= KEY_D; ...
6 years ago (2014-12-11 15:41:37 UTC) #3
rsadam
I'm not familiar with ozone code, deferring to Sadrul as reviewer.
6 years ago (2014-12-12 18:12:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797483002/1
6 years ago (2014-12-12 20:45:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797483002/1
6 years ago (2014-12-13 02:15:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 03:15:16 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-13 03:16:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ad06b87192fa8789c1e8fc6fdd21423883cd2d9
Cr-Commit-Position: refs/heads/master@{#308237}

Powered by Google App Engine
This is Rietveld 408576698