Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 797403005: Revert of Use SuppressFBWarnings to suppress findbugs warnings (Closed)

Created:
5 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use SuppressFBWarnings to suppress findbugs warnings (patchset #12 id:290001 of https://codereview.chromium.org/793203002/) Reason for revert: This is consistently causing bot failures, starting with https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/72002 Original issue's description: > Use SuppressFBWarnings to suppress findbugs warnings > > This has several benefits: > Makes the warning obvious at the place of the problem > Makes suppressing the warnings the same as suppressing compiler and lint warnings > Makes supporting findbugs as part of the build easier > > TBR=rmcilroy, mef, boliu > > BUG=431826 > > Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d > Cr-Commit-Position: refs/heads/master@{#311402} TBR=aurimas@chromium.org,newt@chromium.org,tedchoc@chromium.org,mef@chromium.org,rmcilroy@chromium.org,boliu@chromium.org,cjhopman@chromium.org NOTREECHECKS=true NOTRY=true BUG=431826 Committed: https://crrev.com/14aa2e5d9d1cbf6970ece6535fa1513873ca1057 Cr-Commit-Position: refs/heads/master@{#311417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -114 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 3 chunks +0 lines, -3 lines 0 comments Download
M base/android/java/src/org/chromium/base/PerfTraceEvent.java View 2 chunks +0 lines, -3 lines 0 comments Download
D base/android/java/src/org/chromium/base/annotations/SuppressFBWarnings.java View 1 chunk +0 lines, -20 lines 0 comments Download
M base/android/java/templates/NativeLibraries.template View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/findbugs_filter/findbugs_exclude.xml View 2 chunks +86 lines, -1 line 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 5 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/signin/AccountsChangedReceiver.java View 2 chunks +0 lines, -2 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java View 3 chunks +0 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java View 5 chunks +3 lines, -19 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java View 3 chunks +0 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeFieldsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeReturnValuesTest.java View 3 chunks +14 lines, -16 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeTestBase.java View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Use SuppressFBWarnings to suppress findbugs warnings
5 years, 11 months ago (2015-01-14 06:00:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797403005/1
5 years, 11 months ago (2015-01-14 06:01:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 06:02:05 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 06:02:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14aa2e5d9d1cbf6970ece6535fa1513873ca1057
Cr-Commit-Position: refs/heads/master@{#311417}

Powered by Google App Engine
This is Rietveld 408576698