components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java - Issue 797403005: Revert of Use SuppressFBWarnings to suppress findbugs warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java

Issue 797403005: Revert of Use SuppressFBWarnings to suppress findbugs warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/shell/java/src/org/chromium/chrome/shell/signin/AccountsChangedReceiver.java ('k') | content/public/android/java/src/org/chromium/content/app/ChildProcessService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java

index 05f933fed38ff8f74fd9942190623386aaed1ca9..bd6f31a35204707baae28176ab84a983d5ab5533 100644

--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java

@@ -9,7 +9,6 @@

import org.apache.http.conn.ConnectTimeoutException;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

-import org.chromium.base.annotations.SuppressFBWarnings;

import java.io.IOException;

import java.net.MalformedURLException;

@@ -223,7 +222,6 @@

* @param data The content that needs to be uploaded.

@Override

- @SuppressFBWarnings("EI_EXPOSE_REP2")

public void setUploadData(String contentType, byte[] data) {

synchronized (mLock) {

validateNotStarted();