binary_size: Remove legacy path, keep / as / for unittests on windows

binary_size: Remove legacy path, keep / as / for unittests on windows

Starting on a port to Windows. As the non-legacy path was added 8 months
ago, is it ok to remove the legacy one now?

R=bratell@opera.com, andrewhayden@chromium.org
BUG=441867
Committed: https://crrev.com/b1adcbd2d074e85ec4742d8bad1e30f7228fbcfd
Cr-Commit-Position: refs/heads/master@{#308395}

[scottmg, 2014-12-12 22:30:11]

scottmg@chromium.org changed reviewers:
+ andrewhayden@chromium.org

[scottmg, 2014-12-12 22:31:10]

(I'm not clear on who should review this, let me know who to send subsequent
ones to.)

[scottmg, 2014-12-12 23:00:22]

Hrm, apparently I already wrote this for Windows, so maybe I won't try to port
this one. LMK if you want to remove the legacy path in any case, otherwise, I'll
just close this.

[Daniel Bratell, 2014-12-13 09:17:07]

On 2014/12/12 23:00:22, scottmg wrote:
> Hrm, apparently I already wrote this for Windows, so maybe I won't try to port
> this one. LMK if you want to remove the legacy path in any case, otherwise,
I'll
> just close this.

Removing all the legacy code is a (non-owner) LGTM from me. I've never run is
and I never heard any comments about it so I think it's completely unused and
probably broken.

Where to switch the Windows tools output from \ to / is always a tricky
decision. I think I would try to do it as early as possible so that almost all
shared code can assume paths are / separated.

[Andrew Hayden (chromium.org), 2014-12-15 15:43:23]

LGTM! Thanks for the cleanup. Nobody ever used the legacy reporting stuff AFAIK
and the first thing the Skia team did when they forked this was to delete all
the legacy junk. Seems fine to me!

[scottmg, 2014-12-15 17:46:47]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-12-15 17:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797363002/20001

[commit-bot: I haz the power, 2014-12-15 19:45:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-15 19:46:21]

Patchset 2 (id:??) landed as
https://crrev.com/b1adcbd2d074e85ec4742d8bad1e30f7228fbcfd
Cr-Commit-Position: refs/heads/master@{#308395}